Skip to content

ACM-33132 Review step highlighting too bright in dark mode#6026

Merged
openshift-merge-bot[bot] merged 1 commit intostolostron:mainfrom
jeswanke:ACM-33132-Review-step-highlighting-too-bright-in-dark-mode
Apr 22, 2026
Merged

ACM-33132 Review step highlighting too bright in dark mode#6026
openshift-merge-bot[bot] merged 1 commit intostolostron:mainfrom
jeswanke:ACM-33132-Review-step-highlighting-too-bright-in-dark-mode

Conversation

@jeswanke
Copy link
Copy Markdown
Contributor

@jeswanke jeswanke commented Apr 22, 2026

📝 Summary

CleanShot 2026-04-22 at 16 07 41@2x

Ticket Summary (Title):
ACM-33132 Review step highlighting too bright in dark mode

Ticket Link:
https://redhat.atlassian.net/browse/ACM-33132

Type of Change:

  • 🐞 Bug Fix
  • ✨ Feature
  • 🔧 Refactor
  • 💸 Tech Debt
  • 🧪 Test-related
  • 📄 Docs

✅ Checklist

General

  • PR title follows the convention (e.g. ACM-12340 Fix bug with...)
  • Code builds and runs locally without errors
  • No console logs, commented-out code, or unnecessary files
  • All commits are meaningful and well-labeled
  • All new display strings are externalized for localization (English only)
  • (Nice to have) JSDoc comments added for new functions and interfaces

If Feature

  • UI/UX reviewed (if applicable)
  • All acceptance criteria met
  • Unit test coverage added or updated
  • Relevant documentation or comments included

If Bugfix

  • Root cause and fix summary are documented in the ticket (for future reference / errata)
  • Fix tested thoroughly and resolves the issue
  • Test(s) added to prevent regression

🗒️ Notes for Reviewers

Signed-off-by: John Swanke <jswanke@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 22, 2026

📝 Walkthrough

Walkthrough

CSS styling updates applied to dark theme variants in two components. Opacity values for highlight and match backgrounds reduced from 0.38 to 0.28 alpha in PatternFly dark themes (v5 and v6), enforced via !important directives to ensure visual consistency across dark mode presentations.

Changes

Cohort / File(s) Summary
Dark theme highlight opacity adjustments
frontend/packages/react-form-wizard/src/review/ReviewStep.css, frontend/src/components/SyncEditor/SyncEditor.css
Reduced background-color and outline-color opacity from 0.38 to 0.28 alpha for PatternFly dark theme selectors (.pf-v5-theme-dark, .pf-v6-theme-dark). ReviewStep applies to edit-target and find-match elements; SyncEditor applies to YAML highlight backgrounds.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR description is incomplete. While ticket link, type, and screenshot are provided, most checklist items remain unchecked and critical bugfix-specific items lack required documentation. Check applicable checklist items verified locally. Document root cause and fix summary in the Jira ticket (ACM-33132) for reference. Confirm test coverage for regression prevention.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: addressing dark mode highlighting brightness in the review step component, matching the changeset's CSS theme overrides.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jeswanke jeswanke requested a review from fxiang1 April 22, 2026 20:13
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fxiang1, jeswanke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 07d32bb into stolostron:main Apr 22, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants