https://redhat.atlassian.net/browse/ACM-31312 CIM conversion#8760
Open
oafischer wants to merge 3 commits into2.17_stagefrom
Open
https://redhat.atlassian.net/browse/ACM-31312 CIM conversion#8760oafischer wants to merge 3 commits into2.17_stagefrom
oafischer wants to merge 3 commits into2.17_stagefrom
Conversation
dockerymick
approved these changes
Apr 24, 2026
Contributor
dockerymick
left a comment
dockerymick
left a comment
There was a problem hiding this comment.
Made some suggestions, thanks for your effort and patience!
| :_mod-docs-content-type: | ||
|
|
||
| [#auto-add-hosts-cli] | ||
| = Automatically Adding bare metal hosts to the host inventory by using the command line interface |
Contributor
There was a problem hiding this comment.
Suggested change
| = Automatically Adding bare metal hosts to the host inventory by using the command line interface | |
| = Automatically adding bare metal hosts to the host inventory by using the command line interface |
| @@ -0,0 +1,27 @@ | |||
| :_mod-docs-content-type: | |||
Contributor
There was a problem hiding this comment.
Suggested change
| :_mod-docs-content-type: | |
| :_mod-docs-content-type: PROCEDURE |
Comment on lines
+17
to
+27
| . Add the following annotation to the `BareMetalHost` resource of the node that you want to delete: | ||
| + | ||
| ---- | ||
| bmac.agent-install.openshift.io/remove-agent-and-node-on-delete: true | ||
| ---- | ||
|
|
||
| . Delete the `BareMetalHost` resource by running the following command. Replace `<bmh-name>` with the name of your `BareMetalHost`: | ||
| + | ||
| ---- | ||
| oc delete bmh <bmh-name> | ||
| ---- |
Contributor
There was a problem hiding this comment.
Since it's a short file, figured i share the suggestion lol. If the main focus is script changes, please ignore this suggestion
Suggested change
| . Add the following annotation to the `BareMetalHost` resource of the node that you want to delete: | |
| + | |
| ---- | |
| bmac.agent-install.openshift.io/remove-agent-and-node-on-delete: true | |
| ---- | |
| . Delete the `BareMetalHost` resource by running the following command. Replace `<bmh-name>` with the name of your `BareMetalHost`: | |
| + | |
| ---- | |
| oc delete bmh <bmh-name> | |
| ---- | |
| . Add the following annotation to the `BareMetalHost` resource of the node that you want to delete: | |
| + | |
| [source,bash] | |
| ---- | |
| bmac.agent-install.openshift.io/remove-agent-and-node-on-delete: true | |
| ---- | |
| . Delete the `BareMetalHost` resource by running the following command. Replace `<bmh-name>` with the name of your `BareMetalHost`: | |
| + | |
| [source,bash] | |
| ---- | |
| oc delete bmh <bmh-name> | |
| ---- |
| [#remove-nodes-bm] | ||
| = Removing managed cluster nodes with a bare metal host | ||
|
|
||
| You can remove managed cluster nodes from a managed cluster. Make sure to not delete `NMStateConfig` resources when you delete the agent and bare metal host. |
Contributor
There was a problem hiding this comment.
Suggested change
| You can remove managed cluster nodes from a managed cluster. Make sure to not delete `NMStateConfig` resources when you delete the agent and bare metal host. | |
| [role="_abstract"] | |
| You can remove managed cluster nodes from a managed cluster. Make sure to not delete `NMStateConfig` resources when you delete the agent and bare metal host. |
| [#remove-nodes-wo-bm] | ||
| = Removing managed cluster nodes without a bare metal host | ||
|
|
||
| You can remove managed cluster nodes from a managed cluster. Make sure to not delete `NMStateConfig` resources when you delete the agent and bare metal host. |
Contributor
There was a problem hiding this comment.
Suggested change
| You can remove managed cluster nodes from a managed cluster. Make sure to not delete `NMStateConfig` resources when you delete the agent and bare metal host. | |
| [role="_abstract"] | |
| You can remove managed cluster nodes from a managed cluster. Make sure to not delete `NMStateConfig` resources when you delete the agent and bare metal host. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dockerymick, oafischer The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2.17, 2.16, 2.15, 2.14 (?)