Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BARS-Client-V2.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Hosting" Version="9.0.9" />
<PackageReference Include="Microsoft.Extensions.Logging.Console" Version="9.0.9" />
<PackageReference Include="Microsoft.Extensions.Http" Version="9.0.9" />
<PackageReference Include="Microsoft.Extensions.Http" Version="10.0.10" />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Framework/version mismatch with other Microsoft.Extensions packages

The project targets net8.0-windows (line 5), but Microsoft.Extensions.Http is being bumped to 10.0.10 — a .NET 10 package — while Microsoft.Extensions.Hosting and Microsoft.Extensions.Logging.Console remain at 9.0.9. The Microsoft.Extensions.* suite is designed to be consumed at a consistent major version; mixing .NET 10 and .NET 9 packages can produce runtime type-unification failures and subtle API mismatches. Additionally, .NET 10 packages may have dropped netstandard2.0 support, meaning this package may not be compatible with the net8.0 target at all, potentially causing build or runtime errors.

Prompt To Fix With AI
This is a comment left during a code review.
Path: BARS-Client-V2.csproj
Line: 40

Comment:
**Framework/version mismatch with other Microsoft.Extensions packages**

The project targets `net8.0-windows` (line 5), but `Microsoft.Extensions.Http` is being bumped to `10.0.10` — a .NET 10 package — while `Microsoft.Extensions.Hosting` and `Microsoft.Extensions.Logging.Console` remain at `9.0.9`. The `Microsoft.Extensions.*` suite is designed to be consumed at a consistent major version; mixing .NET 10 and .NET 9 packages can produce runtime type-unification failures and subtle API mismatches. Additionally, .NET 10 packages may have dropped `netstandard2.0` support, meaning this package may not be compatible with the `net8.0` target at all, potentially causing build or runtime errors.

How can I resolve this? If you propose a fix, please make it concise.

<PackageReference Include="DiscordRichPresence" Version="1.6.1.70" />
<PackageReference Include="SimConnect.NET" Version="0.1.15-beta" />
</ItemGroup>
Expand Down
Loading