Release 0.2.2#17
Merged
Merged
Conversation
AussieScorcher
marked this pull request as ready for review
July 23, 2026 04:30
Greptile SummaryThis PR adds livery-aware SimObject creation and improves asynchronous creation error handling. The main changes are:
Confidence Score: 4/5The object-creation flow needs fixes for packet lookup failure and delayed simulator identification before merging.
src/SimConnect.NET/AI/SimObjectManager.cs; src/SimConnect.NET/SimConnectClient.cs Important Files Changed
Prompt To Fix All With AIFix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
src/SimConnect.NET/AI/SimObjectManager.cs:491
**Packet Lookup Orphans Created Object**
When object creation succeeds but `SimConnect_GetLastSentPacketID` fails, this return reports the whole operation as failed and removes its pending request. The simulator can still create the object and send its assigned ID, but the manager then ignores that response, leaving an untracked object that the caller cannot remove.
### Issue 2 of 2
src/SimConnect.NET/SimConnectClient.cs:664
**Identification Deadline Rejects Valid Creation**
`ConnectAsync` marks the client connected before the `OPEN` message completes this task. If that message is delayed for more than five seconds during simulator startup, every object-creation call now fails before reaching either native creation API, even though the connection can remain valid and finish identifying later.
Reviews (1): Last reviewed commit: "Release 0.2.2" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.2.2and add the 2026-07-23 changelog entryWhy
SimConnect reports asynchronous request failures using native packet IDs, while AI object creation was tracking client request IDs. Correlating those identifiers provides prompt, accurate failures and reliable cleanup. The release also adds the MSFS 2024 extended object-creation path needed for modular liveries.
Impact
Consumers can create MSFS 2024 modular SimObjects with liveries, receive richer server-error context, and get explicit timeout failures instead of delayed or mis-correlated object-creation errors. Existing MSFS 2020 object creation continues to use the original API.
Validation
dotnet test SimConnect.NET.sln --configuration Release --no-restore(5 passed)git diff --cached --check