Skip to content

WIP: Add website contribution workflow #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AussieScorcher merged 1 commit into from
Jul 17, 2026
Merged

WIP: Add website contribution workflow #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@ import reactHooks from 'eslint-plugin-react-hooks';
import reactRefresh from 'eslint-plugin-react-refresh';

export default [
{ ignores: ['dist'] },
{
ignores: [
'dist',
'src/features/draft-generator/extractor/**',
'src/features/draft-generator/shims/**',
],
Comment on lines +10 to +13

@greptile-apps greptile-apps Bot Jul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Blanket ignore removes lint coverage from complex parsing code

The extractor and shims directories are excluded entirely to avoid false positives from node: imports, but this also removes ESLint coverage from the most complex files in the PR (bgl.js at ~2100 lines, extract.js at ~2150 lines). A narrower fix would configure a second config entry for those directories with globals.node added — that suppresses the browser-globals false positives while still catching undefined variables, dead code, and logic errors in the binary parsing routines.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: eslint.config.js
Line: 10-13

Comment:
**Blanket ignore removes lint coverage from complex parsing code**

The extractor and shims directories are excluded entirely to avoid false positives from `node:` imports, but this also removes ESLint coverage from the most complex files in the PR (`bgl.js` at ~2100 lines, `extract.js` at ~2150 lines). A narrower fix would configure a second config entry for those directories with `globals.node` added — that suppresses the browser-globals false positives while still catching undefined variables, dead code, and logic errors in the binary parsing routines.

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

},
{
files: ['**/*.{js,jsx}'],
languageOptions: {
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"dev": "vite",
"build": "vite build",
"lint": "eslint .",
"test": "node --test src/features/draft-generator/matching.test.js",
"format": "prettier --write \"src/**/*.{js,jsx,ts,tsx}\" \"**/*.{js,jsx,ts,tsx,json,css,md}\"",
"preview": "vite preview"
},
Expand Down
Loading