fix: prune nested proofs to prevent header size error (#181)#228
Open
Harsh10022004 wants to merge 1 commit intostoracha:mainfrom
Open
fix: prune nested proofs to prevent header size error (#181)#228Harsh10022004 wants to merge 1 commit intostoracha:mainfrom
Harsh10022004 wants to merge 1 commit intostoracha:mainfrom
Conversation
Harsh10022004
requested review from
Peeja,
alanshaw,
hannahhoward and
volmedo
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #181.
This PR addresses the "maximum agent message header size exceeded" error that occurs during delegation storage (
access/delegate). The crash was caused by the system including the full history of nested proofs in the invocation header.Solution
pruneDelegationhelper function which ensures only the single root block of the delegation is included in the message, significantly reducing payload size and preventing the crash.Verification
Tested by running existing and new regression tests within the package.
Command:
go test -v ./pkg/client -run TestAccessDelegate