Conversation
I don't think I actually ran into an issue here, but there's one lying in wait.
This was nearly harmless, as "completing" with `NULL` just writes `NULL` as the CID, which is what it already was. This change fixes two things: 1. We no longer log that we completed something when we didn't. 2. We avoid a theoretical race condition where the correct CID has been written to the DB and we overwrite it with our old `NULL`. I'm not sure we even have enough concurrency for this to be a problem, but the change still feels safer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a few minor fixes and refactors, but mainly this fixes a bad
t_sizecalculation. We ended up setting thet_sizeof a link to the size of the node it points to, when in fact it should be the entire DAG it points to, cumulatively up to the root.We also had a bad calculation in the check, which this also addresses.
PR Dependency Tree
t_sizes correctly #388 👈This tree was auto-generated by Charcoal