Use fedEx (not fedex) for the client variable#4
Merged
Conversation
Align the README examples and tests with the FedEx capitalization convention — the client variable is `fedEx`, matching the `FedEx` constructor. The package name, fedex.com URLs, and the internal cache-key namespace are unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Coverage Report for CI Build 26230777999Coverage remained the same at 100.0%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The README examples and tests instantiated the client as
const fedex = new FedEx({ ... })— lowercasefedex, which doesn't match theFedExconstructor and invites the kind of casing confusion that recently caused a credential mix-up downstream.This aligns the client variable with the FedEx capitalization convention (
fedEx) everywhere it appears as a variable.Changes
const fedEx = new FedEx({ ... })andawait fedEx.<method>(...).fedex→fedExthroughout (64 references).Untouched (correctly lowercase): the package name
@stores.com/fedex,*.fedex.comURLs, and the internal token cache-key namespacefedex:.Testing
node --test --test-force-exit test/index.js— 28 mock-based tests pass, identical to before the rename (the 14 live tests require real FedEx credentials only present in CI). Verified by stashing the change and re-running: same 28 pass / 14 fail, so the rename introduces no regressions.🤖 Generated with Claude Code