Fix error message lost on consumed response body#6
Closed
farhatraiyan wants to merge 3 commits into
Closed
Conversation
Every method calls response.json() then HttpError.from(response) when the 200 response contains an errors array. The body is already consumed so HttpError.from cannot re-read it, producing "200 OK" instead of the actual error message. These 6 TODO tests assert the expected behavior for each affected API. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Coverage Report for CI Build 26520875675Coverage remained the same at 100.0%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
response.json() consumes the body, so the subsequent HttpError.from() call gets an empty clone and falls back to "200 OK" as the message. Replace with createHttpError() that builds the error from the already- parsed JSON, preserving the actual FedEx error messages. Remove TODO markers from the 6 tests that now pass. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mediocrebot
force-pushed
the
fix-error-message-from-consumed-response
branch
from
c6e449e to
7b2d15e
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
response.json()thenHttpError.from(response)when a 200 response contains anerrors[]envelope. Since.json()consumes the body,HttpError.from()gets an empty clone and falls back to"200 OK"instead of the actual FedEx error text.HttpError.from(response, json)(added in@stores.com/http-error@1.2.0) to pass the already-parsed body directly, avoiding the consumed-body problem without cloning.createHttpErrorhelper —http-errornow handles this natively.cancelShipment,createShipment,groundEndOfDayClose,rateAndTransitTimes,trackByTrackingNumber,validateAddress.Commits
err.messagematches the FedEx error text (all fail with"200 OK")createHttpErrorwithHttpError.from(response, json), bump@stores.com/http-errorto~1.2.0, remove TODO markersTest plan
@stores.com/fedex@0.5.1@stores.com/fedexin fulfillment-service (stores-com/fulfillment-service#885)🤖 Generated with Claude Code