Skip to content

Fixed warning on dangling reference to tmp object. #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
volkm merged 1 commit into from
Apr 21, 2026
Merged

Fixed warning on dangling reference to tmp object. #913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/storm/storage/umb/import/SparseModelFromUmb.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@ storm::models::sparse::StateLabeling constructStateLabeling(storm::umb::UmbModel
stateLabelling.addLabel("init", storm::storage::BitVector(numStates, false)); // default to all states not being initial
}
if (umbModel.index.aps().has_value()) {
for (auto const& [apName, apIndex] : umbModel.index.aps().value()) {
auto aps = umbModel.index.aps();
for (auto const& [apName, apIndex] : aps.value()) {
STORM_LOG_THROW(umbModel.aps().has_value() && umbModel.aps()->contains(apName), storm::exceptions::WrongFormatException,
"Atomic proposition '" << apName << "' mentioned in index but no files were found.");
STORM_LOG_THROW(isBooleanType(apIndex.type.type), storm::exceptions::WrongFormatException,
Expand Down Expand Up @@ -159,7 +160,8 @@ auto constructRewardModels(storm::umb::UmbModel const& umbModel) {
using RewardModel = storm::models::sparse::StandardRewardModel<ValueType>;
std::unordered_map<std::string, RewardModel> rewardModels;
if (umbModel.index.rewards().has_value()) {
for (auto const& [rewName, rewIndex] : umbModel.index.rewards().value()) {
auto rewards = umbModel.index.rewards();
for (auto const& [rewName, rewIndex] : rewards.value()) {
STORM_LOG_THROW(umbModel.rewards().has_value() && umbModel.rewards()->contains(rewName), storm::exceptions::WrongFormatException,
"Reward " << rewName << "' mentioned in index but no files were found.");
auto const& rew = umbModel.rewards()->at(rewName);
Expand Down
Loading