add_next_values method on SparseMatrix, much faster _build_sparse_matrix on numpy arrays#382
Open
linusheck wants to merge 1 commit intostormchecker:masterfrom
Open
add_next_values method on SparseMatrix, much faster _build_sparse_matrix on numpy arrays#382linusheck wants to merge 1 commit intostormchecker:masterfrom
linusheck wants to merge 1 commit intostormchecker:masterfrom
Conversation
…rix on numpy arrays
volkm
reviewed
Apr 14, 2026
Contributor
volkm
left a comment
volkm
left a comment
There was a problem hiding this comment.
Looks good. Just one comment.
| } | ||
| size_t groupIdx = 0; | ||
| for (size_t i = 0; i < rows.size(); ++i) { | ||
| while (groupIdx < rowGroupIndices.size() && rowGroupIndices[groupIdx] <= rows[i]) { |
Contributor
|
Merging the master should make the CI run through again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #380. This improves matrix building time a lot in some specific cases, such as loading from numpy arrays.