Draft
Conversation
Contributor
sjunges
commented
Apr 20, 2026
sjunges
commented
- move to sympy for parametric
- submodel via copy that preserves UUIDs
- new reference implementations for qualitative model checking
- new reference implementation for policy iteration.
linusheck
reviewed
Apr 20, 2026
| # for ctmcs and mas we currently only add self loops | ||
| self.add_self_loops() | ||
|
|
||
| def copy(self) -> "Model": |
Collaborator
There was a problem hiding this comment.
this method seems fragile. can't we use copy.deepcopy or similar to do this generically?
Updated Python base image version from 3.12 to 3.13.
…to feat/teaching-policy-iteration
Contributor
Author
|
I would like to do some more tests before review/merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.