feat: add storiesHasSections flag to CmsConfig and UiConfig, enabling…#165
Open
timosville wants to merge 5 commits into
Open
feat: add storiesHasSections flag to CmsConfig and UiConfig, enabling…#165timosville wants to merge 5 commits into
timosville wants to merge 5 commits into
Conversation
… conditional display of Sections tab in story creation and editing
… section field based on hasSections option
Deploying kit with
|
| Latest commit: |
a1f35c5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://683bbc53.kit-atq.pages.dev |
| Branch Preview URL: | https://sco-2697-disable-sections-fr.kit-atq.pages.dev |
…update related tests and story components
Base automatically changed from
sco-2699-pre-fill-content-classification
to
sco-2693-story-publication-is-applied-across-all-langs
July 10, 2026 06:22
Base automatically changed from
sco-2693-story-publication-is-applied-across-all-langs
to
main
July 10, 2026 14:25
JannieT
requested changes
Jul 10, 2026
JannieT
left a comment
JannieT
left a comment
Member
There was a problem hiding this comment.
Several problems with this approach. How about instead of these changes, you only comment out the sections tab in the story-edit and story-config files until the spec is more fleshed out:
const storyEditTabs = computed((): NavigationPaneTab[] => [
{
label: 'Details',
hasError: storyEditTabHasError('details', errors.value),
},
// {
// label: sectionTabLabel.value,
// hasError: storyEditTabHasError('sections', errors.value),
// },
{
label: 'Resources',
hasError: storyEditTabHasError('resources', errors.value),
},
]);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… conditional display of Sections tab in story creation and editing