Skip to content

Issue stratisd 3597 #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
mulkieran wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

Issue stratisd 3597 #1257

mulkieran wants to merge 17 commits into from

Conversation

@mulkieran
Copy link
Member

@mulkieran mulkieran commented Jan 15, 2026

No description provided.

@packit-as-a-service
Copy link

packit-as-a-service bot commented Jan 15, 2026

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/stratis-storage-stratis-cli-1257-copr_pull
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran mulkieran force-pushed the issue-stratisd-3597 branch from 404c5da to d535137 Compare January 15, 2026 16:03
@mulkieran
Only match org.freedesktop.zbus.Error for property setting
cf89a16 
At present, the zbus D-Bus error is the only error that can be returned
when setting a property.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
TEMPORARY: remove manual trigger
a07c82c 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Update introspection data
f04880e 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Set up clevis + keyring options for sharing
a836650 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Add commands for encrypt, re-encrypt, and unencrypt
98d9700 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Test parsing clevis options in encryption on
a3b86ee 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Add an --in-place option
550d4bb 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Half D-Bus timeout
bd000b8 
We had it as high as two minutes to give a chance of returning on fairly
long-running task, like creating encrypted pools, since each device had
to be separately encrypted. We do not do that anymore, as the whole pool
is encrypted these days, so the create method returns faster.

We are about to introduce really long running commands, where 120
minutes will not be enough in almost all cases.

So shortening the D-Bus timeout seems like a reasonable thing to do.

60 seconds is a plenty long time to wait for any error messsages that
stratisd might return.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Add a decorator for our long running operations
b689a69 
This way we can relatively cheaply avoid printing the timeout error
message and return a zero exit code on the timeout.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Display last time re-encrypted in pool detail view
1d0e6d4 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Add man page entries for the moved subcommands
210608f 
These are bind, unbind, and rebind. The new commands use the
mandatory --name, --uuid option mechanism for specifying the pool to
operate on, while the old commands just used name.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
man: Add entries for encryption on, off, and re-encrypt
8e08eec 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
man: Add entry for the "Last Time Reencrypted" field
2c02ad8 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Test exception handling paths of long_running_operation result
b3e85bf 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran force-pushed the issue-stratisd-3597 branch from d535137 to b3e85bf Compare January 15, 2026 17:18
@mulkieran
Copy link
Member Author

mulkieran commented Jan 15, 2026 •
edited
Loading

Right now, we do have the option of making the timeout shorter for our long-running operations than for our other operations. The best way to do this properly is to import only the methods we need in building the dbus-python-client-gen methods and do it exactly where the methods are used. We could still use the public make_class method, but modify the spec file passed to it.

@mulkieran
Remove unnecessary no cover pragma
04dfaf9 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran force-pushed the issue-stratisd-3597 branch from 816930b to 04dfaf9 Compare January 15, 2026 18:40
@mulkieran
Time out after ten seconds for long-running methods
6a529cc 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Abstract that class creation action
10b24d3 
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Copy link
Member Author

mulkieran commented Jan 16, 2026

Long running operation decorator needs to specify the function that is allowed to run for a long time. Otherwise, if it's GetManagedObjects that is the long-running function, "Operation initiated" may be erroneously returned. Should allow it to take a list argument, just to be on the safe side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mulkieran