add Group Channel adaptations on apps #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

plebhash wants to merge 15 commits into stratum-mining:main from plebhash:2025-12-18-adapt-group-channels

Member

plebhash commented Dec 24, 2025 •

edited

Loading

close #146

companion to stratum-mining/stratum#2044

blocked by #154

please note that many commits here are actually coming from #154, and should disappear after it's merged

plebhash changed the title ~~add Group Channel adaptations on apps~~ add Group Channel adaptations on apps 🎅

This was referenced Dec 24, 2025

add Group Channel adaptations on channels_sv2 stratum-mining/stratum#2044

Open

aggregated tProxy sends multiple OpenExtendedMiningChannel messages if clients connect too fast #157

Open

plebhash force-pushed the 2025-12-18-adapt-group-channels branch from 4a0fa49 to c7b55c2 Compare

December 28, 2025 01:16

plebhash changed the title ~~add Group Channel adaptations on apps 🎅~~ add Group Channel adaptations on apps

plebhash force-pushed the 2025-12-18-adapt-group-channels branch from c7b55c2 to 6a9c060 Compare

December 28, 2025 20:29

plebhash mentioned this pull request

tProxy: consider renaming upstream_extended_channel to aggregated_extended_channel #158

Open

plebhash force-pushed the 2025-12-18-adapt-group-channels branch 5 times, most recently from d61670c to b907454 Compare

December 29, 2025 17:33

Member Author

plebhash commented Dec 29, 2025

@lucasbalieiro can you please do some testing with the changes from this PR + stratum-mining/stratum#2044?

please make sure you cover:

no JD + tProxy in aggregated + at least 2 cpu miners
no JD + tProxy in non-aggregated + at least 2 cpu miners
JD + tProxy in non-aggregated + at least 2 cpu miners

Contributor

lucasbalieiro commented Dec 29, 2025

@lucasbalieiro can you please do some testing with the changes from this PR + stratum-mining/stratum#2044?

please make sure you cover:

no JD + tProxy in aggregated + at least 2 cpu miners

no JD + tProxy in non-aggregated + at least 2 cpu miners

JD + tProxy in non-aggregated + at least 2 cpu miners

Working on It

Contributor

lucasbalieiro commented Jan 2, 2026 •

edited

Loading

I was able to do some testing mine some blocks, see if it open more channels than necessary upstream and seems to be working fine. With all the scenarios that you suggested.

I was not able to do longer testing sessions because I need the patch from #138 for my setup to behave better

plebhash commented

View reviewed changes

pool-apps/pool/src/lib/channel_manager/template_distribution_message_handler.rs Show resolved Hide resolved

plebhash commented

View reviewed changes

pool-apps/pool/src/lib/channel_manager/template_distribution_message_handler.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

pool-apps/pool/src/lib/channel_manager/template_distribution_message_handler.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

integration-tests/tests/pool_integration.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

integration-tests/tests/pool_integration.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

integration-tests/tests/pool_integration.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

integration-tests/tests/pool_integration.rs Show resolved Hide resolved

plebhash commented

View reviewed changes

miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

miner-apps/jd-client/src/lib/channel_manager/mod.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

miner-apps/jd-client/src/lib/channel_manager/template_message_handler.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

miner-apps/jd-client/src/lib/channel_manager/template_message_handler.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

miner-apps/jd-client/src/lib/channel_manager/template_message_handler.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

miner-apps/jd-client/src/lib/channel_manager/template_message_handler.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

miner-apps/jd-client/src/lib/channel_manager/template_message_handler.rs Outdated Show resolved Hide resolved

plebhash commented

View reviewed changes

miner-apps/translator/src/lib/sv2/channel_manager/mining_message_handler.rs Show resolved Hide resolved

plebhash commented

View reviewed changes

miner-apps/translator/src/lib/sv2/channel_manager/mining_message_handler.rs Show resolved Hide resolved

plebhash commented

View reviewed changes

miner-apps/translator/src/lib/sv2/channel_manager/mining_message_handler.rs Show resolved Hide resolved

plebhash commented

View reviewed changes

miner-apps/translator/src/lib/sv2/channel_manager/mining_message_handler.rs Outdated Show resolved Hide resolved

plebhash force-pushed the 2025-12-18-adapt-group-channels branch from b907454 to 852c06b Compare

January 4, 2026 18:38

plebhash mentioned this pull request

Adapt to new sv1 handler #160

Merged

plebhash force-pushed the 2025-12-18-adapt-group-channels branch 2 times, most recently from 4018853 to 5d47280 Compare

January 4, 2026 19:51

plebhash marked this pull request as ready for review

January 5, 2026 16:52

plebhash force-pushed the 2025-12-18-adapt-group-channels branch from 5d47280 to b09f733 Compare

January 5, 2026 22:34

plebhash mentioned this pull request

non-aggregated tProxy does not close Sv1 connection after receiving CloseChannel #164

Open

plebhash force-pushed the 2025-12-18-adapt-group-channels branch 3 times, most recently from 188b3ce to 2e564d1 Compare

January 6, 2026 14:30

plebhash added 15 commits

January 6, 2026 11:31


          Pool always groups extended channels

040c4ea


          tProxy handles Group Channels

6c940ed


          JDC always groups extended channels

1a17449


          add hex dependency to integration_test_sv2

fceb81d


          pool_does_not_send_jobs_to_jdc Integration Test also ignores SetNewPr…

0daed28

…evHash


          add pool_group_extended_channels Integration Test

22746b5


          add jdc_group_extended_channels Integration Test

7295c8b


          add pool_group_standard_channels Integration Test

5ccd491


          add jdc_group_standard_channels Integration Test

f2038dc


          add pool_require_standard_jobs_set_does_not_group_standard_channels I…

f016999

…ntegration Test


          add jdc_require_standard_jobs_set_does_not_group_standard_channels In…

cf21cee

…tegration Test


          add aggregated_translator_correctly_deals_with_group_channels Integra…

1f01953

…tion Test


          add non_aggregated_translator_correctly_deals_with_group_channels Int…

f8ba2ad

…egration Test


          add non_aggregated_translator_handles_set_group_channel_message Integ…

39218ba

…ration Test


          add non_aggregated_translator_correctly_deals_with_close_channel_message

42837ee

plebhash force-pushed the 2025-12-18-adapt-group-channels branch from 2e564d1 to 42837ee Compare

January 6, 2026 14:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet