Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
. The real issue was that a lot of cards, tables, and panels in light mode were using very faint transparent backgrounds and borders, so they were basically washing out against the white page. I removed those weak overrides and leaned on the shared surface styles that already exist, which made the UI readable again without changing the look more than necessary. I also added a small safeguard for custom accent colors so button text stays readable.
The earlier PR felt heavier because it touched more unrelated UI and solved the issue with more local tweaks, which makes the code harder to trust and maintain.