Skip to content

add multiple fallback pools#119

Open
xyephy wants to merge 1 commit intostratum-mining:mainfrom
xyephy:2026-04-22-multiple-fallback-pools
Open

add multiple fallback pools#119
xyephy wants to merge 1 commit intostratum-mining:mainfrom
xyephy:2026-04-22-multiple-fallback-pools

Conversation

@xyephy
Copy link
Copy Markdown

@xyephy xyephy commented Apr 23, 2026

Adds support for configuring fallback pools with automatic failover, in both the setup wizard and the settings tab.

  • "+ Add fallback pool" picker in the wizard
  • Editable card list in settings with reorder, remove, Save & Restart
  • TCP reachability check on save catches typos before the restart

Closes #45.
01-initial
02-form-opens-directly
06-duplicate-warning

@pavlenex
Copy link
Copy Markdown
Contributor

pavlenex commented Apr 23, 2026

Quick glance, this PR touches on too many things, making it hard to review. 1300 lines of codes just for adding a simple option to add a fallback pool seems too much. My biggest concern here is that you touched all configuration steps with this as well, so for example now the flow is completely disrupted. For example, now in the setup user can't add custom pool, but it needs to add a fallback pool. I don't know what approach did @GitGab19 have in mind, but this is pretty large scope for a simple feature. On top of that needs rebase and conflict resolving.

@xyephy
Copy link
Copy Markdown
Author

xyephy commented Apr 23, 2026

Quick glance, this PR touches on too many things, making it hard to review. 1300 lines of codes just for adding a simple option to add a fallback pool seems too much. My biggest concern here is that you touched all configuration steps with this as well, so for example now the flow is completely disrupted. For example, now in the setup user can't add custom pool, but it needs to add a fallback pool. I don't know what approach did @GitGab19 have in mind, but this is pretty large scope for a simple feature. On top of that needs rebase and conflict resolving.

I'm simplifying, I realised somethings are already implemented. Now doing cleanup.

@xyephy xyephy marked this pull request as draft April 23, 2026 09:02
@xyephy xyephy force-pushed the 2026-04-22-multiple-fallback-pools branch from 656ba31 to 57df22d Compare April 23, 2026 10:37
@xyephy xyephy marked this pull request as ready for review April 23, 2026 10:42
@xyephy
Copy link
Copy Markdown
Author

xyephy commented Apr 23, 2026

I've pushed a simplified version.

@pavlenex pavlenex force-pushed the 2026-04-22-multiple-fallback-pools branch from 57df22d to 66b5d6c Compare April 24, 2026 06:45
@pavlenex
Copy link
Copy Markdown
Contributor

pavlenex commented Apr 24, 2026

@xyephy Much better and cleaner direction. Thanks for addressing. I was able to test it and my pool correctly fall back to a secondary pool.

On my first test I encountered the issue where in the setting page I wasn't able to edit or add more fallbacks pool, fallback pools completely disappeared, see video.

Screen.Recording.2026-04-24.at.11.56.50.mov

Also CI is failing. It also doesn't seem I can add more than one fallback pool, earlier you had a way to add and drag drop them which imo was good UX.

@plebhash
Copy link
Copy Markdown
Member

@pavlenex do we want to add casa21 as an official option for fallback?

if yes, also for JD?

asking because currently only MP port 3333 is exposed, I'd have to ask to expose the JDP port as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability for users to add multiple fallback pools through the UI

3 participants