fix: read repo YAML key in registry scripts and tighten reload-keys concurrency#378
fix: read repo YAML key in registry scripts and tighten reload-keys concurrency#378streamer45 merged 2 commits intomainfrom
repo YAML key in registry scripts and tighten reload-keys concurrency#378Conversation
… concurrency
- Change plugin.get('repository') to plugin.get('repo') in
build_registry.py and check_registry_versions.py to match the
actual YAML key used in plugin.yml files (#307).
- Add RELOAD_KEYS_MAX_CONCURRENCY (1) for the admin-only reload-keys
endpoint instead of reusing AUTH_MAX_CONCURRENCY (64) (#346).
- Add unit tests for the repo-field mapping in both registry scripts.
Closes #307
Closes #346
Signed-off-by: StreamKit Devin <devin@streamkit.dev>
Co-Authored-By: Claudio Costa <cstcld91@gmail.com>
|
✅ Reviewed on |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
The committed manifest was generated with the old buggy code that read
plugin.get('repository') instead of plugin.get('repo'), so the field
was always None and stripped. Update the manifest to match what the
fixed build_registry.py would produce.
Signed-off-by: StreamKit Devin <devin@streamkit.dev>
Co-Authored-By: Claudio Costa <cstcld91@gmail.com>
ReviewOverall: Clean, minimal fixes. Both changes are correct and well-scoped. Must fix before merge
Looks good
|
Summary
Two small fixes:
bug(marketplace): plugin.yml
repofield silently dropped from registry manifests #307 —plugin.ymlrepofield silently dropped from registry manifestsbuild_registry.pyandcheck_registry_versions.pywere readingplugin.get("repository")but the YAML key inplugin.ymlfiles isrepo. Changed both scripts toplugin.get("repo"). Updated the committed parakeet 0.3.0 manifest to include the previously-missingrepositoryfield. Added unit tests to prevent regression.fix(server): tighten ConcurrencyLimitLayer on reload-keys endpoint #346 — Tighten
ConcurrencyLimitLayeronreload-keysendpointThe admin-only
reload-keysendpoint was usingAUTH_MAX_CONCURRENCY(64). Added a dedicatedRELOAD_KEYS_MAX_CONCURRENCYconstant set to1, since this is a rare admin operation that should not run concurrently.Closes #307
Closes #346
Review & Testing Checklist for Human
repofield now appears in generated registry manifests (runbuild_registry.pyagainst a plugin with arepo:key in itsplugin.yml)reload-keysendpoint returns 503 when a second concurrent request is madeNotes
repositoryfield that was missing due to the bug. The.minisigsignature file will need re-signing on the next registry build.scripts/marketplace/test_build_registry.pycovers therepo→repositoryfield mapping for both scripts.Link to Devin session: https://staging.itsdev.in/sessions/c2210ae7093d4a399c7e7a2a2d478b77
Requested by: @streamer45