Conversation
|
Is there potential for confusion with deciduous trees in winter? Maybe the label "Permanently leafless" or "Leafless all year round" would be clearer? |
|
“leafless” is the tag from OSM, I think I can't change that, but i can change the display name of the option in the app, if that is what you mean. |
|
A leafless tree? What is that? |
According to the wiki a cactus |
That’s completely right, my bad. |
|
Where did you come across a cactus?
El 19 de abril de 2026 11:40:47 CEST, Bjarne Giesker ***@***.***> escribió:
…GieskerB left a comment (streetcomplete/StreetComplete#6820)
> According to the wiki a cactus
> https://wiki.openstreetmap.org/wiki/Tag:leaf_type%3Dleafless
That’s completely right, my bad.
Fixed it!
--
Reply to this email directly or view it on GitHub:
#6820?email_source=notifications&email_token=ABDSDGSKDTPTBP4YIRGMESD4WSNJ7A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMRXGU3DEMRSG432M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4275622277
You are receiving this because you commented.
Message ID: ***@***.***>
|
|
It actually was a dead tree. That's why I added the dead tree option now. But hey! If you come across one you can now simply add it through SC - assuming my pull request gets through :) |
|
I posed these questions because I was trying to find out your use case. So your use case was that you stumbled upon a dead tree and therefore the question about which leaf type this tree had was mu / not applicable. The intended answer the user should give in such a case is to leave a note ( Uh… → Can't Say → Leave Note) and explain why. In this case, write something like "Der Baum ist tot (hat also keine Blätter)". There are innumerable reasons why a quest(ion) may not be answerable. We only include (in the menu opened by the Uh... button) somewhat common cases which otherwise would lead to a flood of notes. So, I am closing this as will not fix. You should just leave a note in cases where the question is not applicable to the real-world situation. Regarding the technical side of your PR, just for your information, it looks good: You created the image correctly, you provided the attribution, didn't choose an excessive JPEG quality and added code to the correct places.
|
|
I added a comment to the discussion on how to tag dead trees, see https://wiki.openstreetmap.org/wiki/Talk:Tag:natural%3Dtree#Dead_tree , I think |
I have added an extra option for the leaf type quest in case the tree has no leafs.
I saw OSM has "leaf_type=leafless" and therefore I added an extra enum entry LEAFLESS(somValue="leafless").
Alongside, I added 4 pictures from wikimedia for displaying.
Do I miss anything? It's my first contribution to Streetcomplete.