Skip to content

Leaf type leafless#6820

Closed
GieskerB wants to merge 7 commits intostreetcomplete:masterfrom
GieskerB:leaf_type_leafless
Closed

Leaf type leafless#6820
GieskerB wants to merge 7 commits intostreetcomplete:masterfrom
GieskerB:leaf_type_leafless

Conversation

@GieskerB
Copy link
Copy Markdown

I have added an extra option for the leaf type quest in case the tree has no leafs.
I saw OSM has "leaf_type=leafless" and therefore I added an extra enum entry LEAFLESS(somValue="leafless").
Alongside, I added 4 pictures from wikimedia for displaying.

Do I miss anything? It's my first contribution to Streetcomplete.

@linfindel
Copy link
Copy Markdown

Is there potential for confusion with deciduous trees in winter? Maybe the label "Permanently leafless" or "Leafless all year round" would be clearer?

@GieskerB
Copy link
Copy Markdown
Author

“leafless” is the tag from OSM, I think I can't change that, but i can change the display name of the option in the app, if that is what you mean.

@westnordost
Copy link
Copy Markdown
Member

A leafless tree? What is that?

@HolgerJeromin
Copy link
Copy Markdown
Contributor

A leafless tree? What is that?

According to the wiki a cactus
https://wiki.openstreetmap.org/wiki/Tag:leaf_type%3Dleafless
But according to this PR image a dead tree.
This discrepance needs to be fixed.

@GieskerB
Copy link
Copy Markdown
Author

According to the wiki a cactus
https://wiki.openstreetmap.org/wiki/Tag:leaf_type%3Dleafless

That’s completely right, my bad.
Fixed it!

@westnordost
Copy link
Copy Markdown
Member

westnordost commented Apr 19, 2026 via email

@GieskerB
Copy link
Copy Markdown
Author

It actually was a dead tree. That's why I added the dead tree option now. But hey! If you come across one you can now simply add it through SC - assuming my pull request gets through :)

@westnordost
Copy link
Copy Markdown
Member

westnordost commented Apr 19, 2026

I posed these questions because I was trying to find out your use case.

So your use case was that you stumbled upon a dead tree and therefore the question about which leaf type this tree had was mu / not applicable. The intended answer the user should give in such a case is to leave a note ( Uh…Can't SayLeave Note) and explain why. In this case, write something like "Der Baum ist tot (hat also keine Blätter)".

There are innumerable reasons why a quest(ion) may not be answerable. We only include (in the menu opened by the Uh... button) somewhat common cases which otherwise would lead to a flood of notes.
I don't see this being the case for neither dead trees nor trees erroneously tagged as cacti.

So, I am closing this as will not fix. You should just leave a note in cases where the question is not applicable to the real-world situation.


Regarding the technical side of your PR, just for your information, it looks good:

You created the image correctly, you provided the attribution, didn't choose an excessive JPEG quality and added code to the correct places.
If this PR was eligible to be merged, there are trhee things I would find fault with, however:

  1. The source strings.xml is the one in commonMain/composeResources/values/. All strings should be added there. There is a gradle task that copies this strings.xml to the other places (androidMain/res/…, commonMain/composeResources/values-en/…, etc.). Also, strings provided in other languages will always be overwritten by imports from PoEditor. ("tot" als adjektiv schreibt man übrigens mit "t")

  2. leaf_type=leafless is not applicable for natural=tree, because there are no trees that are leafless. Cacti are not trees. As far as I can see, the mentioned tag may be used with something like natural=scrub.

  3. I don't know where denotation=dead comes from. It is not documented and it doesn't seem to make sense. denotation is used for... uh... denotation ("Bedeutung"). Whether or not a tree is dead or not doesn't change it's denotation as e.g. a landmark, or as a tree in an avenue ("Allee"), etc. At the moment, I don't know how a dead tree could be tagged.

@westnordost
Copy link
Copy Markdown
Member

I added a comment to the discussion on how to tag dead trees, see https://wiki.openstreetmap.org/wiki/Talk:Tag:natural%3Dtree#Dead_tree , I think dead:natural=tree would be most logical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants