Add support for multiple Docker platforms #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Paulger <stephen.paulger@arm.com>
Contributor
|
Thank you. I need to make sure this is not a breaking change. If it is, it might need to wait until the next version. |
Author
|
The way that it works under the hood is that it builds two images and there's a manifest that takes the place of the current single image. The client uses the manifest to decide which image it prefers and download it. I've done a similar change before (kovetskiy/mark#420). They did already have the QEMU part defined so my only query is whether that is necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should make the image multi-plaform.
There is a chance it will also need qemu setting up.