fix: resolve Windows symlink compatibility in framework validators (#77)#91
Open
striderZA wants to merge 1 commit into
Open
fix: resolve Windows symlink compatibility in framework validators (#77)#91striderZA wants to merge 1 commit into
striderZA wants to merge 1 commit into
Conversation
Update validators to use .agents/ canonical paths directly instead of .opencode/ symlinks, which materialize as plain text files on Windows without Developer Mode (core.symlinks=false), causing ENOTDIR crashes. - tests/workflow/references.mjs: agents/skills/commands dirs → .agents/ - tests/workflow/paths.mjs: skills/commands dirs → .agents/ - tests/workflow/gates.mjs: skills dir → .agents/, commands dirs → .agents/, stale .opencode/docs/ refs → docs/framework/ - tests/workflow/invariants.mjs: agents/skills/commands dirs → .agents/, stale .opencode/docs/ refs → docs/framework/ - tests/modules/validate-modules.mjs: PATH_MAP entries → .agents/ (MODULES_DIR and plugins/ kept as .opencode/ — real dirs, not symlinks) - tests/agents/validate-gdscript.mjs: agents dir → .agents/ All validators pass: 206/206 structural, 4/4 workflow suites, 21/21 modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #77 — framework validators crash with
ENOTDIRon Windows when.opencode/symlinks materialize as plain text files (defaultcore.symlinks=falsewithout Developer Mode).Changes
Updated all validators to resolve
.agents/canonical paths directly, bypassing the symlink layer:tests/workflow/references.mjs.agents/tests/workflow/paths.mjs.agents/tests/workflow/gates.mjs.agents/, stale.opencode/docs/→docs/framework/tests/workflow/invariants.mjs.agents/, stale doc path →docs/framework/tests/modules/validate-modules.mjs.agents/(modules/plugins kept — real dirs)tests/agents/validate-gdscript.mjs.agents/Not affected (intentionally unchanged):
.opencode/modules/and.opencode/plugins/— these are real directories, not symlinks.Verification