Return validity result instead of error for invalid scripts#13
Merged
stringintech merged 1 commit intomainfrom Dec 9, 2025
Merged
Return validity result instead of error for invalid scripts#13stringintech merged 1 commit intomainfrom
stringintech merged 1 commit intomainfrom
Conversation
Change ScriptPubkey.Verify() to align with the C API behavior by returning a boolean validity result rather than treating invalid scripts as errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
ScriptPubkey.Verify()to align with the C API behavior by returning a boolean validity result rather than treating invalid scripts as errors; leaving errors for when verification could not be performed due to malformed input.