NewScriptPubkey: fix panic on empty scriptPubKey#3
Merged
stringintech merged 1 commit intostringintech:mainfrom Nov 7, 2025
Merged
NewScriptPubkey: fix panic on empty scriptPubKey#3stringintech merged 1 commit intostringintech:mainfrom
stringintech merged 1 commit intostringintech:mainfrom
Conversation
Owner
|
Thanks for this and adding test coverage! {
name: "empty_scriptpubkey",
scriptPubkeyHex: "",
amount: 0,
// Minimal coinbase-style transaction with a single empty scriptSig and zero-value output;
// used to trigger verification paths.
txToHex: "01000000010000000000000000000000000000000000000000000000000000000000000000ffffffff00ffffffff0100000000000000000000000000",
inputIndex: 0,
description: "empty scriptPubkey should fail verification",
},Next to that, adding a |
If scriptPubKey is empty, we can't get &scriptPubKey[0] from it.
Contributor
Author
|
@stringintech I removed Nix to another PR: #4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
scriptPubKeyis empty, we can't get&scriptPubKey[0]from it.Also added nix dev shell so I can do
nix developand get all the dependencies loaded.