runner: relabel leash-managed mounts for SELinux#58
Merged
Conversation
Collaborator
Author
|
Addressed follow-up review notes:
Re-ran runner tests:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:zWhy
Issue #57 reproduces on rootless podman + SELinux enforcing because
/leashis mounted from a host temp dir without relabeling.leash-entry-linux-amd64cannot execute, socgroup-pathis never written and startup fails with:failed to locate cgroup path hint: .../cgroup-path not found after waitingValidation
go test ./internal/runner -count=1 -run 'TestWithSELinuxRelabelMode|TestInternalBindMountSpecUsesSELinuxRelabel|TestLaunchContainersAddSELinuxRelabelToInternalMounts|TestLaunchCommandsUseSplitMounts|TestLaunchTargetContainerAppendsAutoMount|TestLaunchTargetContainerAppendsFileMount|TestLaunchTargetContainerSkipsDuplicateMount'leash 1.1.5 --open codexreproduces issue failed to locate cgroup path #57./leash-fixed --open codexpasses cgroup-path/bootstrap stage (no issue failed to locate cgroup path #57)Closes #57