Lg_add_pattern_list return bug by jonstewart · Pull Request #11 · strozfriedberg/lightgrep

b - use the pre-existing internal header for including problematic old Boost program_options, which disables some warnings in a pragma block, instead of the raw Boost header directly. Suppresses ma…

jonstewart

committed

b - fix a warning about an unused function parameter. It's a good warning because it uncovered a function in need of attention, to be done on a separate.

jonstewart

committed

b - lg_create_pattern() was missing a void for its function args, resulting in a warning

jonstewart

committed

r - Change line breaking to be more consistent, the way I like it.

jonstewart

committed

r - C complains about typed function args without variable names (where it's useful in C++ to do this to suppress unused argument warnings). But C is also quite happy for main(void) instead of main…

jonstewart

committed

r - kill off a warning related to comparison of an int vs a size_type (a long) by refactoring this for-loop into a while loop. Initializing i to zero in the initializer of the for-loop, with auto, …

jonstewart

committed

b - suppress unused variable warnings in bison autogen code. It was complaining about yynerrs being set to 0, but never being used.

jonstewart

committed

r - remove commented out #includes from lightgrep_c_util.cpp

jonstewart

committed

R - remove include/container_out.h. It's used only in test translation units and is not necessary there as Catch2 now supplies stream output for containers.

jonstewart

committed

R - Removed warning due to ostream_join_iterator's use of deprecated old-style C++ iterators, by removing it entirely. It was only used in one place for real, and a for-loop is a slightly simpler a…

jonstewart

committed

B - lg_add_pattern_list() was always returning -1 unless it was passed a null pointer for err. This is still gross and needs some refactoring. lg_add_pattern_list() now apes lg_add_pattern() in ret…

jonstewart

committed

R - only copy the default encodings if we're in the branch of them being specified. Pass the encodings into addPatternHelper() as const. Rename 'el' to 'encList'.

jonstewart

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lg_add_pattern_list return bug#11

Lg_add_pattern_list return bug#11
jonstewart wants to merge 12 commits intostrozfriedberg:mainfrom
jonstewart:lg_add_pattern_list-return-bug

Commits on Mar 19, 2025

b - use the pre-existing internal header for including problematic old Boost program_options, which disables some warnings in a pragma block, instead of the raw Boost header directly. Suppresses ma…

b - fix a warning about an unused function parameter. It's a good warning because it uncovered a function in need of attention, to be done on a separate.

b - lg_create_pattern() was missing a void for its function args, resulting in a warning

r - Change line breaking to be more consistent, the way I like it.

r - C complains about typed function args without variable names (where it's useful in C++ to do this to suppress unused argument warnings). But C is also quite happy for main(void) instead of main…

r - kill off a warning related to comparison of an int vs a size_type (a long) by refactoring this for-loop into a while loop. Initializing i to zero in the initializer of the for-loop, with auto, …

b - suppress unused variable warnings in bison autogen code. It was complaining about yynerrs being set to 0, but never being used.

r - remove commented out #includes from lightgrep_c_util.cpp

R - remove include/container_out.h. It's used only in test translation units and is not necessary there as Catch2 now supplies stream output for containers.

R - Removed warning due to ostream_join_iterator's use of deprecated old-style C++ iterators, by removing it entirely. It was only used in one place for real, and a for-loop is a slightly simpler a…

B - lg_add_pattern_list() was always returning -1 unless it was passed a null pointer for err. This is still gross and needs some refactoring. lg_add_pattern_list() now apes lg_add_pattern() in ret…

R - only copy the default encodings if we're in the branch of them being specified. Pass the encodings into addPatternHelper() as const. Rename 'el' to 'encList'.