Phase 1 — regenerated API types - #2
Merged
Merged
Conversation
Generated from the backend contract, not hand-edited. A declined card no longer moves a transaction to FAILED, because that made one decline permanent: create-intent refused anything that was not PENDING, so there was no route back. The reason now lives in its own field and the transaction stays payable. Pairs with bidvault-backend's payments fix (BV-001/005/006/011/054). Additive field, so no contract version bump. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn51EX4kuSFMjKXNY5jVDA
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated from the backend contract, not hand-edited. Pairs with subhanlone/bidvault-backend#2.
WonTransactiongainslastPaymentError.A declined card no longer moves a transaction to
FAILED— that made one decline permanent, becausecreate-intentrefused anything that was notPENDING, leaving the winner with no route back and the seller's item consumed. The reason now lives in its own optional field and the transaction stays payable.Additive, so
api:compatreports no breaking change and no contract version bump is needed.Merge order
This one lands first. Both repos' CI cross-check the other's
master, so a contract change fails the sync step on both sides until one of them merges —frontend/.github/workflows/ci.yml:88-90documents that window as intended. Merging this unblocks the backend's check legitimately, rather than bypassing it there.The optional field is safe to ship ahead of the backend serving it: nothing reads it yet, and its absence is what the type already permits.
Verification
🤖 Generated with Claude Code
https://claude.ai/code/session_01Qn51EX4kuSFMjKXNY5jVDA