Phase 4: data layer and performance (frontend) - #5
Merged
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0114vatC9EkHGSUN9zGfAT3G
Backend companion to bidvault-backend's admin void-transaction route (BV-004, BV-006) -- regenerated openapi.d.ts, a new Transactions screen in the admin sidebar listing every PENDING transaction with a Void action (reason required, kept in the backend's audit log), and BuyerMyWins now shows a "Cancelled" state with a clear message when a transaction is voided instead of falling through with no matching branch. Also surfaces `lastPaymentError` on the PENDING branch, which the backend has published since BV-006 landed but nothing here read: the buyer now sees why the last attempt failed instead of a generic "Complete Payment" with no context. Verified in a browser end-to-end: voided a transaction as admin, watched the toast and list update, then confirmed the buyer's My Wins showed the cancelled state with the right copy. BV-004, BV-006. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0151oceeiAyJdi6T273spk4P
Backend companion to bidvault-backend removing User.cnic entirely -- regenerated openapi.d.ts, dropped the CNIC input, its format validation, and the formatting helper from RegisterScreen.tsx. The field was collected at registration and never read again anywhere in the product; there was nothing left for a keyed hash or encryption to protect, so the decision was to stop collecting it. BV-042. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0151oceeiAyJdi6T273spk4P
Backend companion to bidvault-backend's anonymise-in-place account deletion. Regenerated openapi.d.ts for the three new operations. - DeleteAccountModal: password-confirm dialog, added to a new "Danger Zone" card on BuyerProfile and SellerProfile (mirrors the existing Security card's password-change pattern). Refused server-side if the caller has an active auction or a pending transaction, surfaced as the server's own message. - AdminSettings gains a "Delete a User Account" card: search by email (there is no general user directory, and this is the one occasional, support-driven action that needs one), then a reason-required confirm modal per result. - AuthContext.deleteAccount() clears the local session on success -- the server has already revoked every refresh token, this just makes the app reflect that immediately. Verified in a browser: self-service delete signed the account out with a confirmation toast; admin search-then-delete removed the target from the result list in place. BV-018. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0151oceeiAyJdi6T273spk4P
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
subhanlone
changed the base branch from
fix/phase-3-contract-observability
to
master
August 30, 2026 22:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on Phase 3 (not yet merged). Frontend companion to bidvault-backend's Phase 4 PR.
Test plan
Generated with Claude Code
https://claude.ai/code/session_0151oceeiAyJdi6T273spk4P