fix GetContentDispositionFileName can not correctly handle RFC 6266 specific filename* param#1013
Open
ttys3 wants to merge 1 commit intosubhra74:feature/latest-devfrom
Conversation
…266 specific `filename*` param Refs: https://www.rfc-editor.org/rfc/rfc6266#section-4.3
|
Thnx for this one I confirm it now works like expected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #1012
fix: fix GetContentDispositionFileName can not correctly handle RFC 6266 specific
filename*paramRefs: https://www.rfc-editor.org/rfc/rfc6266#section-4.3
example
content-dispositionheader from Sharepoint storage:https://httpwg.org/specs/rfc6266.html#header.field.definition
https://httpwg.org/specs/rfc6266.html#disposition.parameter.filename
https://www.iana.org/assignments/cont-disp/cont-disp.xhtml
according https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition#directives
The parameters
filenameandfilename*differ only in thatfilename*uses the encoding defined in RFC 5987.When both
filenameandfilename*are present in a single header field value,filename*is preferred overfilenamewhen both are understood.