Fix removal of locked libraries on Windows#1741
Merged
Conversation
This commit moves locked files (e.g. DLLs, pyd) to Data/Trash directory, to defer removal until next restart of ST, while enabling placing new file at the same location upon library upgrade. Technically, charset_normalizer failed to upgrade with WinError 5 due to a .pyd file in Lib/ directory being locked by Windows OS. The strategy is already used by `delete_directory()` function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit moves locked files (e.g. DLLs, pyd) to Data/Trash directory, to defer removal until next restart of ST, while enabling placing new file at the same location upon library upgrade.
Technically, charset_normalizer failed to upgrade with WinError 5 due to a .pyd file in Lib/ directory being locked by Windows OS.
The strategy is already used by
delete_directory()function.