Fixes #82: Missing sync on first transmit.#86
Open
sergiitk wants to merge 2 commits intosui77:masterfrom
Open
Conversation
|
Please see my comment in #82. This may be due to the way that RCSwitch decodes, but the original remotes might not send the signal as you propose. |
|
Confirmed, the original chips send the sync bit after data bits. |
why not both?
Owner
|
why not both? start with a sync bit and allways end with a sync bit. this way devices detecting sync at start would catch the first repetition and devices detecting sync at end would not miss the last repetition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Testing
I used 2 Arduinos:
Then I set
mySwitch.setRepeatTransmit();on the transmitter (2) to a minimum that the receiver (1) would catch every time, in my case 4 times. When set to 3, receiver (1) couldn't catch it.After the change receiver (1) started to catch the code every time with
mySwitch.setRepeatTransmit(3);set.What are the relevant tickets?
Fixes #82.