You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I basically have the issue mentioned in ninjablocks/433Utils#16. @rotv pointed out that there is a fork with a solution which could be applied here (as ninjablocks/433Utils#17 is merged by now). Actually there are a few more forks containing that solution and it appears none has brought it up here.
My biggest concern is that this pulls in another dependency which might not be available / suited for the Arduino. I can imagine using flags to enable these changes only for the RPI or via a new flag.
My biggest concern is that this pulls in another dependency which might not be available / suited for the Arduino. I can imagine using flags to enable these changes only for the RPI or via a new flag.
My feeling was right. I read a bit about Arduino and multitasking and understand now that this approach doesn't make sense for the Arduino. (Even if you use something like ArduinoThread to schedule tasks you would check .available() and not "block a thread".)
I'm not sure what the best approach is to control this via flags. Add a RCSwitchEnableBlockingReceive flag and enable it by default for the RPI? Any other suggestions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on UrbaneChimp/433Utils@3f2517e, I only did the porting.
I basically have the issue mentioned in ninjablocks/433Utils#16. @rotv pointed out that there is a fork with a solution which could be applied here (as ninjablocks/433Utils#17 is merged by now). Actually there are a few more forks containing that solution and it appears none has brought it up here.
I tested these changes with a small change to the 433Utils on a raspberry pi: https://github.com/Locke/433Utils/blob/popEvent/RPi_utils/RFSniffer.cpp
My biggest concern is that this pulls in another dependency which might not be available / suited for the Arduino. I can imagine using flags to enable these changes only for the RPI or via a new flag.