ci: install release Rust targets explicitly - #92
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rustup target addbefore buildingWhy
Release v0.18.0 failed during the musl build with:
Installing the target in an explicit step makes the release workflow fail-fast at target setup and avoids depending on implicit action behavior.
Test plan
go run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/release.ymlpython3structural check for the edited workflow blockrustup target add x86_64-unknown-linux-muslcargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo build --locked --release --target x86_64-unknown-linux-musl; local blocker is missingx86_64-linux-musl-gcc, which the workflow installs viamusl-toolsbefore build