Skip to content

fix bind-attr and action-on-focus deprecations#31

Open
Awem wants to merge 1 commit intosukima:masterfrom
Awem:fix-bind-attr-deprecation
Open

fix bind-attr and action-on-focus deprecations#31
Awem wants to merge 1 commit intosukima:masterfrom
Awem:fix-bind-attr-deprecation

Conversation

@Awem
Copy link

@Awem Awem commented Jul 9, 2015

This is suppossed to fix a few deprecations with latest Ember (CLI). There is still the view "select" deprecation left, which requires more refactoring (see http://emberjs.com/deprecations/v1.x/#toc_ember-select). Maybe solve this in the scope of #30?

The problem with my PR is, that it causes parsing errors (Expecting 'CLOSE_RAW_BLOCK', 'CLOSE', 'CLOSE_UNESCAPED' ....) on elements that appear perfectly fine. I thought maybe updating this addon's Ember might solve this, but this isn't the case. So I think this is a bug with htmlbars or do you have an idea? Nevertheless, I will submit a PR for updating Ember in case you might want it.

@Awem Awem mentioned this pull request Jul 9, 2015
@Awem
Copy link
Author

Awem commented Jul 9, 2015

You can see the parse error at the Travis CI build. I have no idea what is wrong.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No ending }}

<span class="{{if selectionBadge 'badge' 'caret'">{{selectionBadge}}</span>
                                     Missing }}-^

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops!

@sukima
Copy link
Owner

sukima commented Jul 10, 2015

I think it you fix the above syntax error that this should be the first merge. The other PRs are going to need more investigation.

Our company Ember App is also going to need a upgrade so I anticipate having more eyes on this projects upgrade in the near future.

@Awem Awem force-pushed the fix-bind-attr-deprecation branch from 33b5b00 to 496064f Compare July 10, 2015 12:38
@Awem
Copy link
Author

Awem commented Jul 10, 2015

Those failing tests will pass on Ember 1.11.

@sukima
Copy link
Owner

sukima commented Jul 10, 2015

Oh. I get it. Ember 1.10 doesn't support HTMLBars while 1.11 and up does. And so the bind-attr is still required. seems like we should drop < 1.11 support.

@Awem
Copy link
Author

Awem commented Jul 11, 2015

Yes, that would mean Ember CLI 0.2.2+. That version was released on March 30th. I guess it is reasonable to depend on that by now.

@Panman82
Copy link

+1 on this PR. Most addons are indicating which version to use with ember. Eg: ember <= 1.10 use version 1.4.2, ember >= 1.11 use version 1.5+

Also, there are a few places where @each will need to be changed to []. Could be a separate PR or incorporated here IMO.

@sukima
Copy link
Owner

sukima commented Aug 19, 2015

As Ember approaches 2.0 the views will be removed. Eventually the {{select}} helper will be completely refactored. I think it might be worth look at if it is even needed. Maybe have it make it's own on small screen sizes and avoid it completely on desktop. I think the dependency on ember's {{select}} is a source of pain. Can it be removed?

As I have time to work on this plugin I'll leave the 1.x.x versions as old code supporting ember <= 1.10 while the 2.x.x or above is for ember >= 1.13

@Awem
Copy link
Author

Awem commented Aug 19, 2015

{{select}} can certainly be removed. E.g. you could write your own implementation of html's <select> tag or utilize https://github.com/thefrontside/emberx-select.

@sukima
Copy link
Owner

sukima commented Aug 20, 2015

@AW-UC, Exactly, making our own <select> is the way forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants