Skip to content

Embercli3compat #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
directrix1 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Embercli3compat #74

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65bfcdd
Add Ember 3.x support.
directrix1 Jul 11, 2019
85b1a0a
Fixed typo in typeof
directrix1 Jul 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions addon/mixins/select-picker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ const emberArrayFunc = function(method) {
};
};
const _contains = emberArrayFunc(
// Backwards compatability for Ember < 2.x
Ember.Enumerable.keys().indexOf('includes') !== -1 ?
// Backwards compatability for Ember < 2.x and > 3.x
(typeof ((Ember.A()).includes)) === 'function' ?
Copy link
Owner

@sukima sukima Jul 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typeOf is an Ember function. I was using that over native one. This is a departure from the style used on line 11.

'includes' :
'contains'
Copy link
Owner

@sukima sukima Jul 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I get it now. Gee this addon is really messy. Who wrote it? Oh right. now I'm embarrassed.

);
Expand Down