fix(deps): bump markdownlint-cli2 to 0.23.2 to clear npm audit failure - #15
Merged
Conversation
The CI audit step (npm audit --audit-level=moderate) was failing on all Node matrix jobs due to a transitive js-yaml advisory pulled in by markdownlint-cli2@0.23.0 (GHSA-724g-mxrg-4qvm moderate DoS, GHSA-pm4m-ph32-ghv5 high DoS, both in js-yaml 5.0.0-5.2.1). Bump the devDependency to the patch release 0.23.2, which pulls a patched js-yaml (5.2.2) and clears both advisories with no code changes. npm audit now reports 0 vulnerabilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advisories addressed
CI's
npm audit --audit-level=moderatestep (in thenodematrix job) was failing on all three Node versions (20/22/24) with exit 1, since the js-yaml dependency pulled in transitively bymarkdownlint-cli2@0.23.0was affected by two advisories:!!omaptagRemediation chosen
Targeted, semver-compatible bump:
markdownlint-cli2devDependency0.23.0->0.23.2(patch release). This pulls in a patchedjs-yaml@5.2.2transitively along with a few other patch/minor bumps inmarkdownlint-cli2's own dependency tree (globby,markdown-it,markdownlint). No direct runtime dependency changes, no code changes required — this is dev-tooling only (the markdown linter used in CI). Did not runnpm audit fix --force; the fix was applied deliberately viapackage.json+ regeneratedpackage-lock.json.This is the same fix already proposed by the repo's own Dependabot as PR #12 (
dependabot/npm_and_yarn/markdownlint-cli2-0.23.2) — independently arrived at vianpm audit's reportedfixAvailable. Merging this PR should cause Dependabot to auto-close #12 as satisfied; otherwise it can be closed manually as a duplicate.Test evidence (local, Node v26.6.0 — closest available to the CI matrix of 20/22/24)
All steps of the CI
nodejob (checkout, setup-node,npm ci --ignore-scripts,npm run check,npm run lint:markdown,npm audit --audit-level=moderate,npm pack --dry-run) now pass locally. CI will additionally validate against the full Node 20/22/24 matrix, which was not available locally (only Node 26 installed).Nothing requiring an operator decision
Both advisories had a genuine, non-major, dependency-only fix available, so no audit-gate weakening or operator judgment call was needed.