Repository navigation
feat(scan): explain an excluded Go cache instead of omitting it (#619) - #639
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Report rejected Go cache layouts with measured bytes and their cause. Recheck live Go cache authority before cleanup eligibility and project skipped policy as go_cache_unverified. Document unsigned override hiding, unchanged whole-root removal, and independent-provider overlap behavior. Co-Authored-By: Codex <noreply@openai.com>
fc92078 to
eb5c292
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb5c292b56
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if path == "" && target.id == "go-build" { | ||
| var cause string | ||
| path, cause = rejectedGoCache() | ||
| if cause != "" { | ||
| reason = "Go cache unverified: " + cause |
There was a problem hiding this comment.
When upgrading with a scan snapshot written by the previous binary less than five minutes ago, an invalid Go cache is absent from that snapshot, and clean accepts it because this change neither bumps internal/scancache.lastScanCacheSchemaVersion nor changes the provider identity. Consequently the cached cleanup path never executes this new diagnostic branch and omits the required go_cache_unverified row until the snapshot expires or a live scan replaces it; bump the internal scan-cache compatibility revision for this provider behavior change.
AGENTS.md reference: AGENTS.md:L256-L261
Useful? React with 👍 / 👎.
A last-scan snapshot from an earlier version has no go_cache_unverified row, so reusing it would hide the new diagnostic until it expired. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Addressed the snapshot note in 10af90f: the last-scan cache revision is bumped, so a snapshot written by an earlier version is rescanned and the new row appears immediately. |
1 participant
Closes #619.
A Go build cache that failed the layout check (a foreign top-level entry, a symlink, a wrong file type, or an unreadable layout) disappeared from scan and dry-run without explanation. It now appears with a reason and is never selectable.
Go cache unverified: foreign top-level entry "notes.txt".clean --dry-runshows itskippedwith reason codego_cache_unverifiedand leaves its bytes out ofselected_bytes. Age, volume-pressure relaxation, and--forcecannot select it.go-buildidentity so the existing Go-cache safety branch applies.GOCACHEoverride without Go's README signature stays hidden: there is no evidence it is a Go cache.AGENTS.md(replaces "silently exclude" for layout failures),docs/JSON_SCHEMA.md(additive reason code,schema_version1),docs/SPEC.md,docs/CATEGORY.md,skills/aibris/SKILL.md.Decisions are recorded in #619.
Verification
TestGoCacheUnverifiedCLIfailed on the base (row missing).make check,go test -race -count=1 ./...,GOOS=windows go vet ./...: exit 0.🤖 Generated with Claude Code