Skip to content

refactor: shrink backlog-doctor.js and setup-dev-backlog.js to the surviving guards (#446) - #454

Merged
sungjunlee merged 2 commits into
mainfrom
feat/446-shrink-doctor-setup
Sep 17, 2026
Merged

refactor: shrink backlog-doctor.js and setup-dev-backlog.js to the surviving guards (#446)#454
sungjunlee merged 2 commits into
mainfrom
feat/446-shrink-doctor-setup

Conversation

@sungjunlee

@sungjunlee sungjunlee commented Sep 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • backlog-doctor.js 795 → 490: keeps active_sprint, sprint_shape, in_flight_trace, in_flight_staleness, context_bloat (names, per-track tags, schema_version: 1, exit_hint unchanged); drops the reassess-signal counter and accounting, the legacy-root check, and the close-summary/closing-sprint/reassess-threshold flags only they fed. Not ≤ 400: the remaining lines are the five checks' own bodies, and the issue said cut, don't refactor.
  • sprint-close.sh no longer prints a reassess summary (reassess is a human call at close).
  • setup-dev-backlog.js 374 → 150: create root + legacy backlog/ migration only; does not write config.yml (nothing reads it); --tracker accepted and ignored with the notice; GitHub-evidence probe, --project-name, --dry-run removed (no consumer).
  • Docs and _context.md (reassess gotcha) updated. −908 lines. Decided by charter rev 19.
  • Implemented by an Opus 5 subagent; GPT-6 Astra read-only review and an after-run before merge.

Test plan

  • node --test 161 pass (exit 0); bash tests/smoke/smoke-test.sh 165/165 (exit 0); doc-drift OK; live doctor on this repo passes
  • Astra read-only review
  • After-run (both models)

Closes #446 (part of #440).

🤖 Generated with Claude Code

https://claude.ai/code/session_01X9gZYk7FcYSLAZBBe7JXvZ

@sungjunlee @claude
refactor: shrink backlog-doctor.js and setup-dev-backlog.js to the su…
5e8dea9 
…rviving guards (#446)

The doctor keeps only the shared-state checks charter rev 19 admits:
active_sprint (overlap / scopeless warn), sprint_shape, in_flight_trace,
in_flight_staleness, context_bloat. Gone: buildReassessSignal and all its
accounting (closed-sprint counting, triage/*-reassess.md lookup,
sprints_since_last_report, accounting_rule, the reassess_signal JSON key and
its text line), the legacy_execution_root check, and the --close-summary /
--closing-sprint / --reassess-threshold flags that only fed them. Reassess is
a human call at sprint close, not a counter. 795 -> 490 lines.

sprint-close.sh still runs the doctor before the status flip and echoes the
[PASS]/[WARN]/[FAIL] lines under its own "=== Backlog Doctor (pre-close) ==="
header; it no longer prints a reassess summary.

Setup is create-root + legacy `backlog/` migration only: the GitHub-evidence
probe (isGithubRemote / collectGithubEvidence / githubAvailabilityFromEvidence,
no caller outside its own tests) and the undocumented --project-name /
positional name are removed; --tracker, --non-interactive, --json, --help stay.
config.yml is still never written -- nothing reads it. 374 -> 150 lines.
execution-root.js drops the two exports nothing imports.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X9gZYk7FcYSLAZBBe7JXvZ
@coderabbitai

coderabbitai Bot commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: bb746150-c883-4000-bf75-9886c52f412f

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-17T16:49:29.613609Z 5e8dea9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

sungjunlee added a commit that referenced this pull request Sep 17, 2026
@sungjunlee @claude
chore(sprint): #446 on PR #454
76d558a 
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X9gZYk7FcYSLAZBBe7JXvZ
@sungjunlee @claude
docs: record the post-#446 after-run (11/11 both models)
e585f8f 
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X9gZYk7FcYSLAZBBe7JXvZ
@sungjunlee

sungjunlee commented Sep 17, 2026

Copy link
Copy Markdown
Owner Author

GPT-6 Astra read-only review: MERGE. Its one caution (between-sprints active_sprint warn / informational / exit_hint coverage) is still asserted at backlog-doctor.test.js:326-333. After-run 11/11 on both models.

@sungjunlee
sungjunlee merged commit d40c824 into main Sep 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Shrink backlog-doctor.js and setup-dev-backlog.js to the surviving checks

1 participant

@sungjunlee