Repository navigation
refactor: delete sprint-init.js --dry-run/--json surfaces (#457) - #464
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a10eaeccc5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Explicit only (D2): the track axis is never inferred from touched paths. | ||
| const trackAxis = parseTrackAxis(filteredArgs); | ||
| if (trackAxis.error) return { ...trackAxis, dryRun, json }; | ||
| return { topic, milestone, dryRun, json, ...trackAxis }; | ||
| const trackAxis = parseTrackAxis(args); | ||
| if (trackAxis.error) return trackAxis; | ||
| return { topic, milestone, ...trackAxis }; |
There was a problem hiding this comment.
Reject the removed dry-run flag before creating a sprint
When an existing caller still invokes sprint-init.js topic --dry-run, parseArgs now silently ignores the unrecognized flag and main creates an active sprint file, reversing an explicitly non-mutating command into a mutation. Reject removed/unknown flags so stale callers fail without modifying sprint state.
AGENTS.md reference: AGENTS.md:L39-L41
Useful? React with 👍 / 👎.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X9gZYk7FcYSLAZBBe7JXvZ Co-authored-by: Cursor <cursoragent@cursor.com>
…estore lost coverage (#457, Astra review) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X9gZYk7FcYSLAZBBe7JXvZ
|
GPT-6 Astra review (codex, read-only): DO NOT MERGE — P1: retired |
a10eaec to
4c94d59
Compare
Closes #457. Part of #456.
Keep test:
--dry-run/--json/ the structured refusal JSON /issueCount/placeholderIssuehad no consumer outsidetests/; the overlap refusal,COMPONENT_REvalidation, scope line, and skeleton are byte-identical.sprint-init.js372 → 230 lines. Smoke probes that used--dry-run --jsonnow run a real init into their temp dir and read the written file. Implemented by Grok 4.6 (cursor-agent); reviewed by GPT-6 Astra (codex, read-only) before merge.Verified:
node --testgreen, smoke green, doc-drift OK.🤖 Generated with Claude Code
https://claude.ai/code/session_01X9gZYk7FcYSLAZBBe7JXvZ