Skip to content

refactor: delete doctor staleness/bloat checks and dead lib.js readers (#458) - #465

Merged
sungjunlee merged 1 commit into
mainfrom
feat/458-doctor-lib-cuts
Sep 18, 2026
Merged

sungjunlee merged 1 commit into
mainfrom
feat/458-doctor-lib-cuts

Conversation

@sungjunlee

Copy link
Copy Markdown
Owner

Closes #458. Part of #456.

Keep test: in_flight_staleness (--stale-days) is a threshold over age_days that sprint-state.js already emits, context_bloat is wc -l; nothing consumed either. lib.js drops parseMarkerMonth and the triage config readers orphaned by #433. The three guard checks (active_sprint, sprint_shape, in_flight_trace) and their JSON shapes are unchanged. backlog-doctor.js 490 → 389, lib.js 308 → 239. Implemented by Grok 4.6 (cursor-agent); reviewed by GPT-6 Astra (codex, read-only) before merge.

Verified: node --test green, smoke green, doc-drift OK.

🤖 Generated with Claude Code

https://claude.ai/code/session_01X9gZYk7FcYSLAZBBe7JXvZ

#458)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X9gZYk7FcYSLAZBBe7JXvZ
Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: d69faec7-3341-4546-97a1-d54c85104ad8


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-18T00:06:20.517710Z 402e167 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sungjunlee
sungjunlee merged commit 320e738 into main Sep 18, 2026
3 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 402e16726b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 94 to 97
active,
...perTrack.map((run) => run.sprint_shape),
...perTrack.map((run) => run.in_flight_trace),
...perTrack.map((run) => run.in_flight_staleness),
checkContextBloat({ repoRoot: root, sprintsDir, threshold: contextLineThreshold }),
];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the living contract before removing these checks

For stale in-flight work or an _context.md over 200 lines, this list now lets the doctor report no corresponding warning, but spec/capabilities.md:100 still explicitly declares in_flight_staleness and context_bloat as retained doctor checks. Either preserve them or obtain explicit approval and amend the durable capability spec so shipped behavior does not contradict the living contract.

AGENTS.md reference: AGENTS.md:L56-L60

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

backlog-doctor.js: delete staleness and context-bloat checks; lib.js: delete dead config readers

1 participant