Skip to content

fix(relay): reject GitLab MRs targeting different base (#1338) #1339

Closed

Description

@sungjunlee

Banked from #1338 independent review.

When no MR targets baseBranch, fallback selects same-source-branch MRs regardless of target base. Reject MRs whose target ≠ requested base before identity-match / exact-head bind.

Codex P1 on forge-adapters.js.

Activity

  1. sungjunlee commented on Sep 18, 2026

    @sungjunlee
    OwnerAuthor

    구백로그: 1밤 수정. skills/relay-dispatch/scripts/forge-adapters.js에서 requested base와 다른 GitLab MR target을 bind 전에 거절. 열린 PR 없음. backlog. 구현하지 않았습니다.

  2. sungjunlee commented on Sep 21, 2026

    @sungjunlee
    OwnerAuthor

    Next-batch acceptance notes

    This is an existing bounded follow-up, not a new epic. Before implementation, re-read the current forge adapter and check open PR/writer ownership.

    Verify MR selection against the requested target base before identity/exact-head binding:

    • Same source branch with only a different target is not reused.
    • Among multiple targets, only the requested target can be selected.
    • A matching target still needs the existing repository/source/head identity checks.
    • No matching MR follows the documented no-match/create path; rejecting a wrong target must not break legitimate creation.
    • Cover stale heads and the existing GitHub route with focused regression tests.

    Deliver failure reproduction, the minimal adapter change, required checks and final-SHA review evidence in the owning project task. No forge migration, authentication change, remote merge or new runtime framework is needed.

  3. added a commit that references this issue on Sep 21, 2026
    454d845
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    backlogFuture work, not yet prioritized

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions