Skip to content

fix: keep download button alignment stable across zoom levels #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SunnyAgrwl05 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: keep download button alignment stable across zoom levels #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/app/components/Resume/ResumeControlBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ const ResumeControlBar = ({
}, [update, document]);

return (
<div className="sticky bottom-0 left-0 right-0 flex h-[var(--resume-control-bar-height)] items-center justify-center px-[var(--resume-padding)] text-gray-600 lg:justify-between">
<div className="flex items-center gap-2">
<div className="sticky bottom-0 left-0 right-0 flex h-[var(--resume-control-bar-height)] items-center px-[var(--resume-padding)] text-gray-600">
<div className="flex flex-1 items-center gap-2">
<MagnifyingGlassIcon className="h-5 w-5" aria-hidden="true" />
<input
type="range"
Expand All @@ -60,7 +60,7 @@ const ResumeControlBar = ({
</label>
</div>
<a
className="ml-1 flex items-center gap-1 rounded-md border border-gray-300 px-3 py-0.5 hover:bg-gray-100 lg:ml-8"
className="ml-auto flex items-center gap-1 rounded-md border border-gray-300 px-3 py-0.5 hover:bg-gray-100"
href={instance.url!}
download={fileName}
>
Expand All @@ -84,3 +84,7 @@ export const ResumeControlBarCSR = dynamic(
export const ResumeControlBarBorder = () => (
<div className="absolute bottom-[var(--resume-control-bar-height)] w-full border-t-2 bg-gray-50" />
);




9 changes: 8 additions & 1 deletion src/app/components/Resume/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export const Resume = () => {
<NonEnglishFontsCSSLazyLoader />
<div className="relative flex justify-center md:justify-start">
<FlexboxSpacer maxWidth={50} className="hidden md:block" />
<div className="relative">
<div className="relative w-full">
<section className="h-[calc(100vh-var(--top-nav-bar-height)-var(--resume-control-bar-height))] overflow-hidden md:p-[var(--resume-padding)]">
<ResumeIframeCSR
documentSize={settings.documentSize}
Expand All @@ -61,3 +61,10 @@ export const Resume = () => {
</>
);
};