chore: add delta temporality into local otel setup#876
chore: add delta temporality into local otel setup#876ferhatelmas wants to merge 1 commit intomasterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Cache: Disabled due to Reviews > Disable Cache setting Disabled knowledge base sources:
📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR updates OpenTelemetry monitoring: the otel-collector image is bumped to otel/opentelemetry-collector-contrib:0.146.1, the collector config adds a deltatocumulative processor (with max_stale and max_streams) and inserts it into the metrics/otel pipeline, .env.sample sets PROMETHEUS_METRICS_ENABLED=false and adds OTEL_METRICS_TEMPORALITY=DELTA, and the Grafana storage dashboard title and uid are updated to indicate pull-based OTel metrics. Sequence Diagram(s)sequenceDiagram
participant App as Application
participant OTEL as OTEL Collector
participant Prom as Prometheus
participant Graf as Grafana
App->>OTEL: emit metrics (delta)
OTEL->>OTEL: deltatocumulative processor (convert delta -> cumulative)
OTEL->>Prom: expose metrics endpoint
Prom->>OTEL: scrape metrics
Prom->>Graf: serve metrics for dashboards
Graf->>Graf: display "Storage API - OTel Metrics - Pull"
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@monitoring/otel/config/otel-collector-config.yml`:
- Around line 229-230: The processors list references a name mismatch: the
configuration uses "delta_to_cumulative" but the processor is defined as
"deltatocumulative"; update the processors array entry so the referenced
processor name exactly matches the defined symbol (replace "delta_to_cumulative"
with "deltatocumulative" or rename the processor definition to
"delta_to_cumulative") so the processors list (memory_limiter,
deltatocumulative, transform/add_resource_attributes, metricstransform/host,
batch/metrics) matches exactly.
ℹ️ Review info
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Cache: Disabled due to Reviews > Disable Cache setting
Disabled knowledge base sources:
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
.docker/docker-compose-monitoring.yml.env.samplemonitoring/grafana/dashboards/storage.jsonmonitoring/otel/config/otel-collector-config.yml
ferhatelmas
force-pushed
the
ferhat/delta
branch
from
7ed740b to
3af21b3
Compare
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
ferhatelmas
force-pushed
the
ferhat/delta
branch
from
3af21b3 to
7b1f662
Compare
2 participants
What kind of change does this PR introduce?
chore
What is the current behavior?
Delta metrics aren't supported in local otel collector.
What is the new behavior?
It's supported.
Bump version otel collector to have deltatocumulative processor (what prom supports).
Rename old grafana dashboard to have distinct uid so that they don't override each other.
Additional context
Might want to clean up pull based metrics later on.