fix: prevent decoded content length spoofing#907
Merged
ferhatelmas merged 1 commit intomasterfrom Mar 13, 2026
Merged
Conversation
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
fenos
approved these changes
Mar 13, 2026
itslenny
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
x-amz-decoded-content-lengthis prefered over content-length. This can be spoofed by the user.What is the new behavior?
This header should be preferred only for aws-chunked S3 requests (valid signature).
Additional context
Related to #906