increase kMaxSynthGrains in JoshGrainUGens#261
increase kMaxSynthGrains in JoshGrainUGens#261dyfer wants to merge 1 commit intosupercollider:mainfrom
Conversation
|
thanks @dyfer - there is, actually, and we do it in the main line grain UGens that were based on these UGens. Basically, you add a parameter in the UGen that lets the user pass in the max number of grains, and RTAlloc the space for them. That is a big change to THESE UGens though and may break backward compatibility. You can see an example from this page: https://github.com/supercollider/supercollider/blob/develop/server/plugins/GrainUGens.cpp Notice the RTAlloc in next_k IF this is the first run. The value is read from the UGen input, then allocated. I'd suggest first seeing if something similar can be done without breaking backward compatibility, and if so, that would be a better fix. If backward compatibility would be broken, I'm fine with what you have already submitted.... please let me know! |
joshpar
left a comment
There was a problem hiding this comment.
Please see main comment on thread and let me know what you think.
|
Thanks @joshpar I'll look into it. |
|
bump @dyfer |
Occasionally I am running into exceeding the number of grains.
This just arbitrarily
exceedsincreases the maximum, but maybe there is a better way to do this?