Fix memory allocation bug in JPVerb#416
Merged
capital-G merged 4 commits intosupercollider:mainfrom Jan 29, 2026
Merged
Conversation
Spacechild1
approved these changes
Jan 28, 2026
capital-G
force-pushed
the
jpverb-memory-fix
branch
from
6e476b0 to
aa61075
Compare
Contributor
Author
|
@Spacechild1 - sorry for re-pining. I also fixed some memory leaks while I am at it and made the error handling more generic, please check if this is okay. If so I think this is ready to be merged (not squashed). |
Spacechild1
requested changes
Jan 28, 2026
also set default calc function
Contributor
Author
|
ping @Spacechild1 |
Spacechild1
reviewed
Jan 29, 2026
Spacechild1
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old code uses
If RTAlloc fails, it will return a nullptr: but putting an instance of FAUSTCLASS (or anything at all) to the nullptr is undefined behavior and will lead to a crash.