fix(super-editor): normalize API tab insertions#2830
Draft
missysuperdoc wants to merge 2 commits intosuperdoc-dev:mainfrom
Draft
fix(super-editor): normalize API tab insertions#2830missysuperdoc wants to merge 2 commits intosuperdoc-dev:mainfrom
missysuperdoc wants to merge 2 commits intosuperdoc-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
tabnodes instead of raw textWhy this changed
API-driven insertions were preserving
\tinside text nodes, which exported to raw tab characters inside<w:t>instead of proper<w:tab/>runs.Impact
API insertions now match the editor's native tab model, and DOCX export emits valid Word tab runs for both direct and tracked document API writes.
Validation
pnpm --prefix packages/super-editor exec vitest run src/editors/v1/document-api-adapters/write-adapter.test.tspnpm --prefix packages/super-editor exec vitest run src/editors/v1/extensions/track-changes/track-changes-extension.test.jspnpm --prefix packages/super-editor exec vitest run src/editors/v1/document-api-adapters/write-tabs-export.integration.test.ts