feat(executor): add tab character to tab node conversion in text insert#2832
feat(executor): add tab character to tab node conversion in text insert#2832andrii-harbour wants to merge 1 commit intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4a3cd90a8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const tabNodeType = editor.state.schema.nodes.tab; | ||
| if (tabNodeType && text.includes('\t')) { |
There was a problem hiding this comment.
This branch converts any \t to schema.nodes.tab whenever the tab type exists, but it never verifies that a tab node is valid at absPos. That regresses cases where text insertion happens inside containers that allow only text* content (for example total-page-number in extensions/page-number/page-number.js): previously a raw tab character could be inserted as text, but now tr.insert(absPos, fragment) can throw a schema replace error and abort the whole plan execution. Please check parent compatibility (canReplace/canInsert) and fall back to text-node insertion for tabs when tab is not allowed at the target position.
Useful? React with 👍 / 👎.
2 participants
No description provided.