SD-2526 - feat: implement 2 extra types of bullet lists (square, circle)#2857
SD-2526 - feat: implement 2 extra types of bullet lists (square, circle)#2857chittolinag wants to merge 4 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce505e4c06
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| role="menuitem" | ||
| :aria-label="button.ariaLabel" | ||
| ref="buttonRefs" | ||
| @keydown.prevent="(event) => handleKeyDown(event, index)" |
There was a problem hiding this comment.
The @keydown.prevent modifier on each bullet-style option prevents default behavior for all keys, not just the handled arrows/Enter. In practice, once focus is inside this menu, pressing Tab cannot move focus to the next control, which creates a keyboard trap for keyboard-only users when the dropdown is open. This should only prevent default for keys you explicitly handle.
Useful? React with 👍 / 👎.
| listRendering: { | ||
| keepOnSplit: false, | ||
| renderDOM: ({ listRendering }) => { | ||
| console.log('listRendering', listRendering); |
There was a problem hiding this comment.
This console.log runs inside renderDOM for paragraph attributes, so it executes repeatedly during normal editing and state updates. On real documents this will spam logs, slow down interactive rendering, and expose list metadata in production consoles, which is typically unintended for a hot render path.
Useful? React with 👍 / 👎.
3 participants
Introducing two new types of bullet lists: square (▪) and circle (◦).
Even though we supported rendering the styles when opening documents from Word, the user couldn't start a new list using square or circle.
This PR introduces a dropdown that allows the user to do so.