-
Notifications
You must be signed in to change notification settings - Fork 195
fix(super-editor): flip tooltip when clipped by viewport #3836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dani-beltran
wants to merge
18
commits into
superdoc:main
Choose a base branch
from
dani-beltran:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
85ca5d4
fix(super-editor): toolbar tooltips are not cut off by edge of the wi…
dani-beltran 9280d31
chore(super-editor): refactor ToolbarDropdown to use anchored-positio…
dani-beltran 98aaca6
chore(super-editor): refactor FontFamilyCombobox to use anchored-posi…
dani-beltran 692cca4
chore(super-editor): added test for the SdTooltip fliping fix
dani-beltran bde822f
chore(super-editor): added test for anchored-position utility fns
dani-beltran efcc505
fix(super-editor): avoid edge case where popover positioning could go…
dani-beltran b27f96e
fix(super-editor): measuring full menu height for dropdowns dynamic p…
dani-beltran ce793a3
fix(super-editor): tooltip animation origin matches its position
dani-beltran 09a2bca
chore(super-ditor): removed unnecesary code
dani-beltran 38aea83
fix(super-editor): context menu no more clipping outside editor
dani-beltran 1118b3f
chore(super-editor): update tests for components using anchored posit…
dani-beltran 6a5c6f1
chore(super-editor): added tests for anchored-position util new param…
dani-beltran a04b194
fix(super-editor): positioning available space on top and left update…
dani-beltran 2edbe98
chore(super-editor): restored context menu original behaviour
dani-beltran 49be664
fix(super-editor): anchored position function take boundary into acco…
dani-beltran 49b2547
chore(super-editor): update anchored position util tests
dani-beltran 5ff59f6
fix(super-editor): flip anchored position for the secondary axis as well
dani-beltran 58e18f0
chore(super-editor): refactor font family combobox to avoid redundant…
dani-beltran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the animation origin to be position agnostic, since the tooltip could be now on top or bottom positions. It looks good, barely noticeable difference. However, this is modifying the original animation, so I am considering changing it.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a simple solution to make the animation origin match the dynamic tooltip position. 🟢