Fix undo and redo after collaboration upgrade - #3851
Draft
jelkes1 wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upgradeToCollaboration()attaches collaboration in placeRoot cause
EditorHistorySnapshotAdaptercached whether the editor was collaborative in its constructor. The unified history coordinator creates the adapter while the editor is still local, so an instance later upgraded withupgradeToCollaboration()continued reading the removed ProseMirror history stack. Undo and redo depths therefore remained zero even when the Yjs UndoManager contained entries, leaving both controls disabled.Impact
Editors upgraded from local mode to collaboration now expose the Yjs undo/redo depths to the unified history coordinator and toolbar.
Validation
vitesthistory adapter, coordinator, and PresentationEditor suites: 199 passed, 5 skippedvitestupgrade-collaboration.test.js: 14 passedgit diff --check: passedThe package-wide
types:checkremains red on existing unrelated JS/TS migration errors across the package; no reported error points to either changed file.